Conversation
the future. It must be today or earlier. Note that today/now is relative to UTC.
…tentctl into date_cannot_be_future
Contributor
Author
|
Note - current failures against production branch of security_content are to be expected until a fix is merged into that repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate an error during content validation if the date is set for the future.
Note that this is relative to UTC, so there are some minor edge cases where this generates an exception based on the locale of a developer. This is documented in the error message returned however.
Note this is what the new check shows on our repo today, in which a piece of content accidentally has a future date:
